Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AssetMetadataByIds endpoint of ShieldedPool service #4688

Closed
turbocrime opened this issue Jul 2, 2024 · 1 comment
Closed

Implement AssetMetadataByIds endpoint of ShieldedPool service #4688

turbocrime opened this issue Jul 2, 2024 · 1 comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@turbocrime
Copy link
Contributor

turbocrime commented Jul 2, 2024

async fn asset_metadata_by_ids(
&self,
_request: tonic::Request<AssetMetadataByIdsRequest>,
) -> Result<tonic::Response<Self::AssetMetadataByIdsStream>, tonic::Status> {
unimplemented!("asset_metadata_by_ids not yet implemented")
}

any client using the web block processor will be ratelimited immediately when attempting genesis block sync. this is due to the massive number of requests issued during initial validator discovery (currently, there are 437 validators).

PR exists at penumbra-zone/web#1392 in web to avoid the behavior, but most of these requests could become a single request if this batch request endpoint were implemented.

@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jul 2, 2024
@Valentine1898
Copy link
Contributor

This is a duplicate of #4162 that was closed in favor of penumbra-zone/web#1189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Status: Done
Development

No branches or pull requests

3 participants