-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit use of panicky-macros #4446
Comments
It should only interrupt the connection right? if it makes the full node panic we need to do this immediately |
i'm not sure if there is comet behavior involved when you say "full node panic" but yes, |
I just tested this by adding a panic to the This work may not need to be completed after all, or is at least lower-priority than we initially thought. |
In #4444 @cratelyn noted that the use of the
unimplemented!()
macro in RPCs can allow a malicious client to crash the node software.I performed a brief search through the codebase and saw several other calls to
unimplemented
elsewhere. We should audit the codebase for panicky macros (panic
,unimplemented
,todo
, etc.) and ensure they're unable to crash node software.The text was updated successfully, but these errors were encountered: