Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting as setup.py #289

Closed
frostming opened this issue Mar 5, 2021 · 7 comments · Fixed by #290
Closed

Support exporting as setup.py #289

frostming opened this issue Mar 5, 2021 · 7 comments · Fixed by #290
Labels
⭐ enhancement Improvements for existing features

Comments

@frostming
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

@frostming frostming added the ⭐ enhancement Improvements for existing features label Mar 5, 2021
@lazarillo
Copy link
Sponsor Contributor

I don't understand why this was closed. The code clearly says that it is not implemented yet:

def export(project: Project, candidates: list, options: Any | None) -> str:
    raise NotImplementedError()

source

What am I missing?

@frostming
Copy link
Collaborator Author

Supporting it is not in the plan.

@pawamoy
Copy link
Sponsor Contributor

pawamoy commented Nov 23, 2023

It was removed later, when switching to the new backend, which does not support it: 7894d18#diff-508d4fe890214310b46011513969196b21755b8a9b2019578ad1120787c3dc84

@frostming
Copy link
Collaborator Author

Yes, that was an action towards supporting unspecific build backends. Since converting pyproject.toml, especially the build config depends on what build backend you are using. PDM doesn't have enough knowledge to convert it.

@lazarillo
Copy link
Sponsor Contributor

Should I make a PR to update the docs to clarify this?

@frostming
Copy link
Collaborator Author

Should I make a PR to update the docs to clarify this?

Go ahead

@lazarillo
Copy link
Sponsor Contributor

Here it is: #2481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants