Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level cherry pick solution does not match problem. #1143

Closed
nimbius opened this issue May 10, 2024 · 3 comments
Closed

level cherry pick solution does not match problem. #1143

nimbius opened this issue May 10, 2024 · 3 comments

Comments

@nimbius
Copy link

nimbius commented May 10, 2024

answer should be cherry-pick C3 C5 C7, solution shows C3 C4 C7

@PiotrNowek
Copy link

PiotrNowek commented May 24, 2024

Hi :)
I found a bug in the learnGitBranching project. Here are the details:

Description:
In lesson 1 level 3(main) program except answer cherry-pick C3 C4 C7 in final task, I expected answer cherry-pick C3 C5 C7. The program did not skip to the next lesson.

Expected Behavior:
Answer cherry-pick C3 C5 C7 is correct

Actual Behavior:
Answer cherry-pick C3 C4 C7 is correct

Screenshots/Logs:
2024-05-24 11_24_47-Learn Git Branching — Mozilla Firefox

Environment:

  • OS: Windows 7
  • Browser: Mozilla Firefox ESR(x64pl)
  • Version: v 115.11.0

Thanks for looking into this!

Peter

@Conmandouglas
Copy link

The solution is indeed correct, and this is false. Let me explain. So currently, the HEAD is checked out at c1 with main, so anything cherry-picked will continue the branch, as you can see. If you use git cherry-pick c4 it will add just c4 to the branch. So in this case, when you check the goal image with the Show Goal button, or the goal command, on the far right you can see the main branch is continued, and what branches to commit. You see at the top, c3, which means that is the first value you enter. Then you see c4, and then c7. This means the solution to this issue would be git cherry-pick c3 c4 c7 which is what the solution says.
In short, this issue should be marked as resolved, and the solution is correct as far as I can observe. The solution, according to the code itself, is in the following: "solutionCommand": "git cherry-pick C3 C4 C7", which is correct.

@pcottle
Copy link
Owner

pcottle commented Oct 6, 2024

Thanks @Conmandouglas for taking a look!

@pcottle pcottle closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants