Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanups #6

Merged
merged 4 commits into from
Jul 3, 2019
Merged

minor cleanups #6

merged 4 commits into from
Jul 3, 2019

Conversation

toppk
Copy link
Contributor

@toppk toppk commented Jun 19, 2019

just starting to use your library, and i found some minor issues, so I thought I'd quickly shoot them over your way. haven't actually used the library yet, but looks good so far :)

these should be straight forward changes, happy to explain further if needed.

@coveralls
Copy link

coveralls commented Jun 19, 2019

Coverage Status

Coverage remained the same at ?% when pulling ec0e1df on toppk:master into 2a48803 on paulokuong:master.

@paulokuong
Copy link
Owner

@toppk thanks will take a look

@toppk
Copy link
Contributor Author

toppk commented Jun 26, 2019

okay. just switch the import to absolute to the style used elsewhere.

@paulokuong paulokuong merged commit c93a609 into paulokuong:master Jul 3, 2019
@paulokuong
Copy link
Owner

@toppk thanks

@a-d-collins
Copy link

@paulokuong @pkuong the tar.gz contents available on pypi for version 0.1.17 of this package (https://pypi.org/project/noaa-sdk/0.1.17/#files) do not match those of the master branch that resulted from merging this pull-request. Do you have plans to release that soon? In python 3.73 envs I get dependency errors that relate to requests 2.21 (which was changed in this branch).

Also, it looks like Requests 2.22.0 dropped support for python 3.4 (https://2.python-requests.org/en/master/community/updates/#id1), so if you need help when it comes to supporting 3.73, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants