Support patternengine name rather than file extension in the template tab #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI can put it in the template tab if it's there.
geoffp
changed the title
|
Tested this with a local copy of pattern-lab/styleguidekit-assets-default#44 with and without values - works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #446
Summary of changes:
Hey, it's a one-liner. We just drop the engine name into the pattern data block on the pattern's rendered html page. The UI can be updated to use it, but otherwise will ignore it.
See also:
Bonus: I believe this change is harmless even if support is missing in styleguidekit-assets-default. Likewise, I believe the proposed change to styleguidekit-assets-default is harmless even if this change isn't present.