Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please review #59

Merged
merged 12 commits into from
Oct 28, 2018
Merged

Please review #59

merged 12 commits into from
Oct 28, 2018

Conversation

aseigler
Copy link
Collaborator

@aseigler aseigler requested a review from abergs October 19, 2018 23:09
@abergs
Copy link
Collaborator

abergs commented Oct 21, 2018

Will hopefully be able to review tomorrow. Github says it has conflicts but not sure if that's a false alarm?

@aseigler
Move attestation format specific code out to their own files, simplif…
c8bdead 
…y and improve readability
@aseigler
Additional cleanup and reorganization.
c3313a1 
Adding a failing test captured from conformance tool ALG_SIGN_SECP521R1_ECDSA_SHA512_RAW.
@aseigler
Copy link
Collaborator Author

I haven't seen any conflicts?

@abergs
Copy link
Collaborator

abergs commented Oct 25, 2018

This is the Github UI, but I can try to do it manually.

Do have any more commits or are you good to go?

image

@aseigler
Copy link
Collaborator Author

That's bizarre...this is what I see.
20181025_061233

I don't have anything else right at the moment, I was mainly concerned about adding the CBOR and Chaos.NaCl projects. It works fine for me, just wanted to make sure it works for you and that it was done properly.

@abergs
Copy link
Collaborator

abergs commented Oct 25, 2018

I think that is because I run the rebase and merge mode.
I will take a look at it and test locally 👍

@abergs abergs merged commit df445ba into passwordless-lib:master Oct 28, 2018
@abergs abergs added the enhancement Enhancements or general improvements label May 28, 2020
@abergs abergs mentioned this pull request May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs Awaiting requested review from abergs

Assignees
No one assigned
Labels
enhancement Enhancements or general improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security] Remove dependency on PeterO.Cbor package
2 participants
@aseigler @abergs