Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct AuthenticatorAssertionRawResponse.Id type #513

Open
Regenhardt opened this issue Mar 6, 2024 · 0 comments
Open

Correct AuthenticatorAssertionRawResponse.Id type #513

Regenhardt opened this issue Mar 6, 2024 · 0 comments

Comments

@Regenhardt
Copy link
Contributor

The AuthenticatorAssertionRawResponse class has two byte[] members Id and RawId. Both used, although RawId is just checked for existence and in tests.

As per MDN Id is literally the base64url encoded value of RawId, I think Id should rather be a string and not base64url-decoded when received, but kept as string. The places currently using the Id property should use RawId instead.

I just debugged into an assertion, and Id and RawId do indeed have the exact same value in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant