Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use MDS on attfmt "none"? #46

Closed
abergs opened this issue Oct 4, 2018 · 5 comments
Closed

Do not use MDS on attfmt "none"? #46

abergs opened this issue Oct 4, 2018 · 5 comments
Labels
enhancement Enhancements or general improvements

Comments

@abergs
Copy link
Collaborator

abergs commented Oct 4, 2018

I think you are the best to answer this @aseigler:
My understanding is that MDS is not useful on "none" and "self" so we should not check or initiate the MDS on those formats, correct?

@aseigler
Copy link
Collaborator

aseigler commented Oct 4, 2018

Any case where the attested credential data has aaguid present could be an authenticator that should be verified to not have an undesirable status listed against it in the MDS, so I think that would be true for "none", but not "self". Note that the MDSMetadata class is implemented as a singleton so initiating an instance doesn't actually cost anything after the first call instantiation.

@abergs
Copy link
Collaborator Author

abergs commented Oct 4, 2018

@aseigler I now configured my MDS with accesstoken and cacheDir ".\mdscache". It creates the folder sucessfully and stores the mdstoc.jwt in it, but crashes on filenotfound when running

GetMetadataStatement("07a9f89c-6407-4594-9d56-621d5f1e358b", true).

I think you should be able to replicate by cleaning your cache folder?

@abergs
Copy link
Collaborator Author

abergs commented Oct 4, 2018

update: I think this parameter should be changed from true -> fromCache?
https://github.com/abergs/fido2-net-lib/blob/swappable-mds/fido2-net-lib/MetadataService.cs#L521

I changed it and it worked.

@abergs abergs changed the title Do not use MDS on attfmt "none" & "self"? Do not use MDS on attfmt "none"? Oct 8, 2018
@abergs abergs added the enhancement Enhancements or general improvements label Oct 8, 2018
@aseigler
Copy link
Collaborator

I think I am going to move all of the MDS related stuff into the packed attestation area. There are finally real authenticators in MDS now.

@aseigler
Copy link
Collaborator

aseigler commented Dec 6, 2018

Closed by #63

@aseigler aseigler closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements or general improvements
Projects
None yet
Development

No branches or pull requests

2 participants