Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwordless Demo failing in 4.0.0-beta2 (master) #402

Closed
trankin opened this issue Jun 22, 2023 · 2 comments
Closed

Passwordless Demo failing in 4.0.0-beta2 (master) #402

trankin opened this issue Jun 22, 2023 · 2 comments

Comments

@trankin
Copy link

trankin commented Jun 22, 2023

I found a couple of issues causing this to fail when testing the passwordless feature of the demo.

Registration is failing out of the box because when posting to /makeCredential extensions.credOpts used to be true and is now {rk: true}, This is causing a binding error on the AuthenticatorAttestationRawResponse object.

/makeCredential was further failing because when storing the credential to DemoStorage Descriptor is null because success.Result.CredentialId is no longer being populated in AuthenticatorAttestationResponse.cs. This fails silently on registration and appears to be successful, but Sign In will fail because the credential can't be found when doing /assertionOptions.

@abergs
Copy link
Collaborator

abergs commented Jun 26, 2023

Thanks for testing these issues. We have a very long running branch #277 that we need to merge. @aseigler Do you even think it's possible to merge that branch or should we just create new smaller PR's that add some of the changes you did?

@abergs
Copy link
Collaborator

abergs commented Aug 11, 2023

Fixed in #411

@abergs abergs closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants