Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubKeyCredParams[n].alg serialization issues #263

Open
StummeJ opened this issue Nov 5, 2021 · 3 comments
Open

pubKeyCredParams[n].alg serialization issues #263

StummeJ opened this issue Nov 5, 2021 · 3 comments

Comments

@StummeJ
Copy link

StummeJ commented Nov 5, 2021

After upgrading Fido2 from 1.1.0 to anything 2.0.0 or above we're seeing an incorrect serialization of the publicKeyCredParams[n].alg values. I've seen some things about the type being serialized incorrectly to a number, but cannot find anything about the alg being serialized incorrectly as a string. I also noticed there were some changes to the alg to move it from a long to an enum.

New lib error:

image

New:

image

Old:

image

@aseigler
Copy link
Collaborator

I can't reproduce this. The strings coming out of the alg values are weird enough, but the dashes that are getting added in the middle are really bizarre. Not really sure where that is coming from.

@Binaryraja
Copy link

Binaryraja commented Feb 22, 2022

With this change, We are unable to call navigator.credentials.create. Exception occurs. The same code works with Nuget Package 1.1.0 where the pubKeyCredParams[n] is hardcoded.

Tested in
Microsoft Edge
Version 97.0.1072.69 (Official build) (64-bit)

@iamcarbon
Copy link
Sponsor Contributor

@Binaryraja Were you able to figure this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants