Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async API signatures #19

Closed
abergs opened this issue Aug 17, 2018 · 4 comments
Closed

Add async API signatures #19

abergs opened this issue Aug 17, 2018 · 4 comments

Comments

@abergs
Copy link
Collaborator

abergs commented Aug 17, 2018

To support async / await callbacks.
Also add Async callback signatures.

Should just mirror existing names but append "Async", e.g. MakeAssertionAsync

@abergs
Copy link
Collaborator Author

abergs commented Aug 19, 2018

Or should we leave the storage of counter / public key creds responsibility to the call site? Might be better when I think about it.

Async might be needed for metdata services however. Leaving this open.

@aseigler
Copy link
Collaborator

Wouldn't hurt to provide a sample storage facility for counter/public keys in the form of an in-memory database. Would be excellent for proof of concept.

@abergs
Copy link
Collaborator Author

abergs commented Aug 19, 2018

Sure, but I'm still leaning to have it at the call site as separate methods. Async might be needed in the callback for ICredentialUniqueToUser though (since that will need to scan storage)

@abergs
Copy link
Collaborator Author

abergs commented Aug 20, 2018

Done. DevStorage added in 2d866a5#diff-43a3af1c06c320b60ef91be4cfbf21f0

Unfortunalte ReadOnlySpans are not allowed when methods are async which increases byte[] copying.

@abergs abergs closed this as completed Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants