Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more defensive exceptions #16

Closed
abergs opened this issue Aug 14, 2018 · 5 comments
Closed

Add more defensive exceptions #16

abergs opened this issue Aug 14, 2018 · 5 comments
Labels
enhancement Enhancements or general improvements

Comments

@abergs
Copy link
Collaborator

abergs commented Aug 14, 2018

We pass a lot of the "Expect failure" tests in the conformance tool, e.g:

image

But it's often because of null reference etc. Might be better for a library consumer if we threw more precise exceptions.

@abergs abergs added the enhancement Enhancements or general improvements label Aug 14, 2018
@aseigler
Copy link
Collaborator

Put in a good amount of this.

@abergs
Copy link
Collaborator Author

abergs commented Aug 17, 2018

Do we have many more to add or should we go ahead and close? (unable to run the testing tool for a couple of days)

@aseigler
Copy link
Collaborator

I have a few more, then it's mostly fixing cert and sign parsing issues for all the data samples.

@aseigler
Copy link
Collaborator

Attestation code is fairly well defended now, with the exception of certificate parsing.

@abergs
Copy link
Collaborator Author

abergs commented Sep 28, 2018

I think we should go ahead and close this now. Please reopen if you deem necessary.

@abergs abergs closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements or general improvements
Projects
None yet
Development

No branches or pull requests

2 participants