-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using 1Password does not work on demo #30
Comments
Hi,
Accroding to the specs:
So opening a ticket for 1Password would be more suited, so that they become compliant to the specs. That said, that 1Password implements providing the public key makes more sense rather than all developers having to work around the lack of this critical convenience function. Lastly, it would bloat this slim library with an additional undesired CBOR dependency. The specs require it and all major browsers/platforms comply to it (the lagging behind Firefox recently implemented it, see #18) so I see no reason to bloat this lib. That said, I'd of course accept a PR for this feature if the CBOR dependency is loaded dynamically "on demand". |
Trying the demo at https://webauthn.passwordless.id/demos/basic.html, I found that using 1Password to save my passkey doesn't work. 1P will save the passkey, but the client can't unpack the response to send it to the server.
Here's a demo of what I mean:
Screen.Recording.2023-08-18.at.16.43.28-2.mp4
I found this out by using the webauthn client in my own project and confirmed it in the basic demo. In my project, I saw errors that
getPublicKey()
didn't exist. I believe that is optional, so it's not too surprising.Do you have any suggestions on what can be done to support 1Password? I can look at making changes, but I don't know the Webauthn spec that well. I know your project is focused, so you may not want to support these kinds of authenticators at all.
Using both my browser and a remote authenticator (my phone) did work. It's just 1Password and it's weird responses that doesn't.
This the credential created by 1Password:
and the
response
:the
clientDataJSON
:The text was updated successfully, but these errors were encountered: