-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parea wrapper not re-raising root exception #166
Labels
bug
Something isn't working
Comments
Hey, thanks for raising! I will update you once it's resolved. |
@seanr-cardless it's fixed now with #168! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
The Parea wrapper code returns in the
finally
block which swallows the exception caught when actually calling the OpenAI models. This makes things very difficult to log/monitor/debug as the root exception is swallowed by Parea and failures occur downstream.Link to offending code.
parea-sdk-py/parea/wrapper/wrapper.py
Line 137 in bffcada
🔬 How To Reproduce
Steps to reproduce the behavior:
Code sample
Try running this function. 1 is returned and the exception isn't raised
Environment
📈 Expected behavior
The error isn't swallowed by Parea and is surfaced to the consumer of the Open API call.
📎 Additional context
I ran into this using Langchain with the following (abbreviated) code
This became relevant on the OpenAI outage on 2023-10-19
The text was updated successfully, but these errors were encountered: