Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add remove_block_and_execution_range #9432

Merged
merged 3 commits into from
Jul 11, 2024
Merged

feat: add remove_block_and_execution_range #9432

merged 3 commits into from
Jul 11, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jul 10, 2024

This allows for removing the block range without returning it.

Also adds remove_state

@Rjected Rjected added C-enhancement New feature or request A-db Related to the database labels Jul 10, 2024
mattsse
mattsse approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Rjected and others added 3 commits July 11, 2024 16:49
@Rjected
feat: add remove_block_and_execution_range
a9bc7a2 
This allows for removing the block range without returning it.
@Rjected @shekhirin
fix doc issues
0af1f3f 
Co-authored-by: Alexey Shekhirin <[email protected]>
@Rjected
cargo fmt
a4c0d9b
@Rjected Rjected force-pushed the dan/introduce-remove-block-execution-range branch from b1a30be to a4c0d9b Compare July 11, 2024 20:49
@Rjected Rjected enabled auto-merge July 11, 2024 20:56
@Rjected Rjected added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit e8a6fe1 Jul 11, 2024
32 checks passed
@Rjected Rjected deleted the dan/introduce-remove-block-execution-range branch July 11, 2024 21:14
@joshieDo joshieDo mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-db Related to the database C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @shekhirin @mattsse