Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm custom chainspec parser #8998

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore: rm custom chainspec parser #8998

merged 1 commit into from
Jun 20, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 20, 2024

genesis_value_parser does the same thing, no need to have it twice

Rjected
Rjected approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jun 20, 2024
@mattsse mattsse enabled auto-merge June 20, 2024 18:43
@mattsse mattsse added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 27d26ac Jun 20, 2024
31 checks passed
@mattsse mattsse deleted the matt/rm-chainspec-parser branch June 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattsse @Rjected @onbjerg @DaniPopes