Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move forkcondition and displayhardfork types to fork crate #8909

Merged
merged 3 commits into from
Jun 18, 2024
Merged

move forkcondition and displayhardfork types to fork crate #8909

merged 3 commits into from
Jun 18, 2024

Conversation

lakshya-sky
Copy link
Contributor

@lakshya-sky lakshya-sky commented Jun 17, 2024 •
edited
Loading

Closes: #8901

@lakshya-sky lakshya-sky force-pushed the chore/move-display-hard-forks branch from e5e1935 to 6d8ae14 Compare June 18, 2024 04:42
@mattsse mattsse marked this pull request as ready for review June 18, 2024 11:26
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jun 18, 2024
mattsse
mattsse approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mattsse mattsse enabled auto-merge June 18, 2024 11:43
@mattsse mattsse added this pull request to the merge queue Jun 18, 2024
Merged via the queue into paradigmxyz:main with commit fe817c0 Jun 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move displayHardforks to ethereum-forks crate
2 participants
@lakshya-sky @mattsse