Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dont depend on reth-primitives #8762

Merged
merged 2 commits into from
Jun 12, 2024
Merged

chore: dont depend on reth-primitives #8762

merged 2 commits into from
Jun 12, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 11, 2024 •
edited
Loading

blocked by #8729

remove reth-primitives dep and use individual deps instead

@mattsse mattsse force-pushed the matt/rm-reth-primitives-dep branch from d383045 to 17d5770 Compare June 11, 2024 20:57
@mattsse mattsse marked this pull request as ready for review June 11, 2024 20:57
@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Jun 11, 2024
@mattsse mattsse added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 1c148e7 Jun 12, 2024
30 checks passed
@mattsse mattsse deleted the matt/rm-reth-primitives-dep branch June 12, 2024 00:09
emhane pushed a commit that referenced this pull request Jun 13, 2024
@mattsse @emhane
chore: dont depend on reth-primitives (#8762)
431872f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes