Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tables_to_generic! macro to convert between table values and types #8518

Merged
merged 1 commit into from
May 30, 2024

Conversation

DaniPopes
Copy link
Member

No description provided.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@DaniPopes DaniPopes marked this pull request as draft May 30, 2024 17:44
@DaniPopes
Copy link
Member Author

I was thinking about replacing tableviewer with this but tbh i prefer the trait. This macro does the same thing but has a simpler API

@DaniPopes DaniPopes marked this pull request as ready for review May 30, 2024 18:19
@DaniPopes DaniPopes enabled auto-merge May 30, 2024 18:19
@DaniPopes DaniPopes added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 2a8a693 May 30, 2024
30 checks passed
@DaniPopes DaniPopes deleted the dani/tables-to-generic branch May 30, 2024 18:40
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants