-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move core rpc server types to standalone crate #8515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great start
with a standalone, lightweight crate we can also pull this in in reth-rpc and move the constants to reth-rpc-server-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solid,
next we need the remaining types that are used in node-core
@mattsse Can you please have a look at my last commit and tell me if I'm heading in the right direction? Feels like I'm moving the entire |
I see, the main problem is this config trait: reth/crates/node-core/src/cli/config.rs Line 18 in e75edf3
hmm, this is a bit tricky, I need to think about this a bit, okay, for this pr, let's only do constants first, get the pr over the line and then continue with more incremental changes. it's fine if node-core then also depends on server-types. |
This reverts commit 41bf574.
@mattsse I think this is ready to be reviewed. P.S.: Don't hesitate if you can think of some good first issues for the next steps :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
next we can move these constants and types for cache
reth/crates/node-core/src/args/rpc_state_cache.rs
Lines 2 to 5 in 13fcb88
use reth_rpc::eth::cache::{ | |
DEFAULT_BLOCK_CACHE_MAX_LEN, DEFAULT_CONCURRENT_DB_REQUESTS, DEFAULT_ENV_CACHE_MAX_LEN, | |
DEFAULT_RECEIPT_CACHE_MAX_LEN, | |
}; |
then I think we move the config traits
ref #8460