-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save last finalized block #8473
Conversation
d261633
to
3b11598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, storing finalized is sound imo because finalized, hehe
pending @rkrasiuk
unwinds should probably clear this one out if it goes beyond this block. this can happen when manually calling unwind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
what are you suggesting? what needs to be done? |
if there's a pipeline unwind that goes beyond that block, replace it with a lower one on Finish stage unwind fn |
@joshieDo cool thx! we should save the lowest one that results from the unwind operation, right? either |
e5ebb0b
to
eaec49d
Compare
9c91eb7
to
6750cea
Compare
Closes #1712
Prevents potential issues with fixed finality depth on adverse conditions, there are no fixed bounds to finality depth and the actual finalized block can be earlier than a
last_finalized_block_number
initialized to a fixed value.