Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing helper functions and docs #3646

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 6, 2023

subpool is part of public api and should have additional helpers

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Jul 6, 2023
@mattsse mattsse requested a review from rkrasiuk July 6, 2023 22:51
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3646 (c08b653) into main (b8a5476) will decrease coverage by 20.24%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/transaction-pool/src/pool/state.rs 45.76% <0.00%> (-42.92%) ⬇️

... and 265 files with indirect coverage changes

Flag Coverage Δ
integration-tests ?
unit-tests 47.00% <0.00%> (-17.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 14.81% <ø> (-11.59%) ⬇️
blockchain tree 74.16% <ø> (-7.10%) ⬇️
pipeline 58.33% <ø> (-28.36%) ⬇️
storage (db) 56.17% <ø> (-16.36%) ⬇️
trie 76.49% <ø> (-18.17%) ⬇️
txpool 39.48% <0.00%> (-9.66%) ⬇️
networking 52.76% <ø> (-24.56%) ⬇️
rpc 26.02% <ø> (-23.46%) ⬇️
consensus 52.39% <ø> (-10.91%) ⬇️
revm 24.30% <ø> (-9.72%) ⬇️
payload builder 4.36% <ø> (ø)
primitives 60.39% <ø> (-27.53%) ⬇️

@gakonst gakonst added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit 5cc55db Jul 7, 2023
26 checks passed
@gakonst gakonst deleted the matt/add-missing-helpers-and-docs branch July 7, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants