Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ForkChoiceNotifications trait for BlockchainProvider and NoopProvider #9521

Closed
mattsse opened this issue Jul 15, 2024 · 3 comments
Closed

Implement ForkChoiceNotifications trait for BlockchainProvider and NoopProvider #9521

mattsse opened this issue Jul 15, 2024 · 3 comments
Assignees
@royvardhan
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 15, 2024

Describe the feature

reth/crates/storage/provider/src/traits/chain.rs

Line 150 in 80b02fe

pub trait ForkChoiceSubscriptions: Send + Sync {

similar to

image

but implemented for BlockchainProvider and NoopProvider

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Jul 15, 2024
@greged93
Copy link
Contributor

Hey @mattsse im down to work on this if possible

@royvardhan
Copy link
Contributor

@mattsse Please assign this to me.

@mattsse mattsse assigned royvardhan and unassigned greged93 Aug 2, 2024
This was referenced Aug 3, 2024
Closed
Closed
Merged
@royvardhan
Copy link
Contributor

We can close this? @mattsse

@mattsse mattsse closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@royvardhan royvardhan

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattsse @royvardhan @greged93