-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use alloy transaction types #9484
Comments
I can take this on. |
cool, this will likely be a bit painful, see #9485 for ref |
@mattsse Looking into this, it seems I will have to convert from reth For instance in the code below, I would like to call reth/crates/primitives/src/transaction/pooled.rs Lines 303 to 306 in cbe9a7c
|
is the end goal to replace |
|
the core tx types are quivalent to alloy's:
reth/crates/primitives/src/transaction/eip1559.rs
Line 13 in 67f6176
the only difference is the codec impl
reth/crates/primitives/src/transaction/eip1559.rs
Line 11 in 67f6176
we can implement codec by doing the same as for
reth/crates/storage/codecs/src/alloy/withdrawal.rs
Lines 6 to 11 in 67f6176
TODO
This should be done in separate prs and involves
there are likely missing/renamed functions in alloy, so we need to surface those and add to alloy if appropriate
The text was updated successfully, but these errors were encountered: