Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How secret service integration works? #338

Closed
AmirHosseinKarimi opened this issue Jan 17, 2024 · 3 comments
Closed

How secret service integration works? #338

AmirHosseinKarimi opened this issue Jan 17, 2024 · 3 comments

Comments

@AmirHosseinKarimi
Copy link

According to #275 new versions of OTPClient do not ask for the password and are opened by the power of the secret service.
As a user, I am worried about the security of my database file.
Also, as a programmer, I want to know how it works.

So, In the past versions, the database file was encrypted by password and OTPClient asked for the password to open the database.
But where is the password storage in the current version?

I'd appreciate it if someone explained about this important change in the details.

@paolostivanin
Copy link
Owner

Hello,
secret service integration is provided by libsecret, a widely used library, so I trust those devs to have built something secure 😄
A short gist about libsecret can be found here: https://superuser.com/questions/1527816/what-is-libsecret , while what is secret service can be found here: https://specifications.freedesktop.org/secret-service/latest/

If you don't trust secret service, you can always disable it by toggling "Settings -> Enable secret service".

@AmirHosseinKarimi
Copy link
Author

Hi,
It's not about whether I trust this service or not. As a user, I wonder when the software does not ask for the password.
When it happened for the first time I wondered if I changed any setting that removed the password and decreased my database file security.

Finally, I think it is a good idea to show a message to the user and inform them about the changes that applied in the new version and settings that have been changed automatically.

@paolostivanin
Copy link
Owner

It actually should show an info bar when upgrading from a non-enabled secrect service installation to one that supports it (

set_info_bar (app_data, _("Not asking for password? Please check the 'Secret Service Integration' new feature <a href=\"https://github.com/paolostivanin/OTPClient/wiki/How-to-use-OTPClient#secret-service-integration\">HERE</a>"));
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants