Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between ccd.SDKDriver.get_devices() and AbstractSDKCamera._cameras (bug) #1020

Open
danjampro opened this issue Oct 21, 2020 · 0 comments
Open

Inconsistency between ccd.SDKDriver.get_devices() and AbstractSDKCamera._cameras (bug) #1020

danjampro opened this issue Oct 21, 2020 · 0 comments
Assignees
@wtgee @AnthonyHorton @danjampro

Comments

@danjampro
Copy link
Collaborator

danjampro commented Oct 21, 2020 •
edited
Loading

AbstractSDKCamera._cameras are expected to have keys of camera serial_numbers, but ccd.SDKDriver creates them as name: port. This leads to an InvalidConfig error. The reason the tests are currently passing is that the device name for the ccd camera is the same as its serial number.

ccd.SDKDriver:

POCS/src/panoptes/pocs/camera/simulator/ccd.py

Line 23 in 804e48d

def get_devices(self):

AbstractSDKCamera._cameras:

POCS/src/panoptes/pocs/camera/sdk.py

Line 98 in 804e48d

my_class._cameras = my_class._driver.get_devices()

@danjampro danjampro changed the title Inconsistency between ccd.SDKDriver and AbstractSDKCamera._cameras (bug) Inconsistency between ccd.SDKDriver.get_devices() and AbstractSDKCamera._cameras (bug) Oct 21, 2020
@wtgee wtgee assigned AnthonyHorton and unassigned jlibermann Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wtgee wtgee

@AnthonyHorton AnthonyHorton

@danjampro danjampro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wtgee @AnthonyHorton @danjampro @jlibermann