Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderMulti causes errors in header #659

Closed
gduffy100 opened this issue May 19, 2015 · 4 comments
Closed

RenderMulti causes errors in header #659

gduffy100 opened this issue May 19, 2015 · 4 comments

Comments

@gduffy100
Copy link

Hi Chris,

Great script and application structure, nice logical flow and easy to find things.

Just tried to implement renderMulti for a new view and it created an error in the header file where the active class if statements were looking for the variable $filename, which is now no longer defined. Wondering if you have an elegant solution to this issue in mind.

Maybe making $filename $filenames in all cases and always referencing $filename[0].

@gduffy100
Copy link
Author

I added a line into the render multi function before the call to header as follows:

$filename = $filenames[0];

This resolves the issue because now $filename exists

@jjkirkpatrick
Copy link
Contributor

$filename already exists, it's one of the parameters, if it doesn't exist then you have not set it

@panique
Copy link
Owner

panique commented May 20, 2015

Hey, this feature was build by an external author, so I cannot really say something. :(
But a big thanks for the fix, I'll put this into the project in the next days!

@gduffy100
Copy link
Author

Hi oisian,
$filename is only instantiated in renderMulti after the call to header. Before that you only have the $filenames variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants