[REFACTORING] LoginController only for login flow

[slaveek]

Hi.
Looking through changes in LoginController I began to think about some methods in it.
My impression is that some of the methods like:

showProfile, editUsername, uploadAvatar, changeAccountType
(all which need authentication)

are not quite related to login process.

This methods are created to do user actions after login process (edit, upload, show etc.) and don't have nothing to do with correct, safe login.

IMHO it's worth to consider in future to separate this methods in eg. UserController.
This can:

• keep LoginController to do login / logout process and make it very tiny
• let user to do all actions in UserController. It's also good place to put more user actions later.
• bring more logic in url's:
  • user/editusername instead of login/editusername
  • user/uploadavatar instead of login/uploadavatar
  • user/changeaccounttype instead of login/changeaccounttype

It can be a bit cleaner I think.

Just idea.
Take care.

[panique]

Hey slaveek, a very very good point! Thanks, I'll do this in the next days.
I have a very good feeling on the new version, things are going into a beautiful direction here!

Have a wonderful evening/day/morning :)

[M0W93]

Oh Yeah this is a nice Idea :D 👍

[Dominic28]

Yes sounds great! I did this with the user profiles on a project, too.

[panique]

Done! This is just a first preview, everything might change for sure!

[panique]

in develop branch btw

[slaveek]

Hi Chris
I see that this issue is marked as done and closed but no changes in LoginController. Is not that a bit small mistake ;) ? I think that the idea here was to clean LoginController (look at the issue title).
Maybe that's because of LoginModel changes.

BTW LoginModel looks so good now. The model directory is very clear and easy to navigate. It's extremely easy to find function that you need.

Shouldn't LoginController and controller dir look similar to model?

[panique]

@slaveek Ah damn, you're right! I've indeed just cleaned the model, not the controller. Okay, ticket is open again. :)

Changes will come around beginning of FEbruary.

[panique]

Okay, the changes will take a liiiittle bit longer :)

[panique]

Thanks to everybody, this is now done by slaveek's commit via #747