-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need enhancement #32
Comments
this script does not handle it. however, you can edit the database. personaly i use phpmyadmin for this. its simple and there a lot of info in the internet about it. |
thanks for the reply, but do you think can we give authorise for user to edit their own account? |
Phpmyadmin in a database administrator tool. You don't want your users in! And PHP-Login can't do it. So, unless someone commit a peice of code that do it, it's a sad no. |
ok i customized the page already :) |
it shoud create a new file and include it on request like index.php?edit_user Im waiting to see my pull request accepted or denided after, i will work on that and nonce. (Poking Panique :P) |
so i have to add some script to login_class.php and make new php file named user_edit or kinda. or just put it on logged_in.php since logged_in.php only accessable by logged in user? |
i just need php mysql query for update data.. anyone? thanks,, |
@riefkhy can you rewrite that sentence, i dont know what you mean |
@panique I wrote so many comments, can you clarify which sentence in which comment? I also added some fields e.g firstname,lastname,phone. Now, I am stuck at user edit page, where if I hit edit information button, nothing happened. Here is the function of edit data I tried : (I put this in Login.class.php)
|
sorry for the messed up comment I just made, I dont know how to make it neater. |
@riefkhy Sorry, i meant the last one. Cannot figure out what you want to say... |
@panique answered though, I meant this part $query_edit_user = $this->connection->query("UPDATE users SET first_name, last_name, user_name, user_email, user_password_hash, phone, birthday, gender, country = '".$this->edit_user_name."', '".$this->edit_user_password_hash."', '".$this->edit_user_email."', '".$edit_phonenumber."', '".$this->edit_first_name."', '".$this->edit_last_name."', '".$edit_date."', '".$this->edit_gender."', '".$this->edit_country."' WHERE user_name = '".$this->user_name."';"); is it correct? |
@riefkhy Why do you want to add user data management functionality into login functionality? Makes no sense to me at all. Better to seperate the two and NOT to add it into the class login. Giving the (registered) user the ability to change his/her username, password, etc. has nothing to do with giving the (registered) user the ability to login. Same holds for the registering part of this script. An improvement would be to seperate the registering part from the class login and move it to some other class like class user. One should keep in mind the difference between login functionality and (user) data management. The first is about permissions regarding (parts of) an application, the second is about data management (create, read, update, delete) regardingone or more data collections. |
Coming up in the 2-advanced version of the script. |
hi, thanks for the very beautiful works u have done and shared.
but i am stuck at some parts, bcoz i am also new at this languange, i could learn from your abt mysql and php connection but, can you make a page or giving and example for updating user information and delete user? thanks you
The text was updated successfully, but these errors were encountered: