Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grpc): add Proposal to ConsensusInfo API #1469

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat(grpc): add Proposal to ConsensusInfo API #1469

merged 1 commit into from
Aug 23, 2024

Conversation

maxipaz
Copy link
Contributor

@maxipaz maxipaz commented Aug 12, 2024

Description

Adding Proposal to the ConsensusInfo gRPC proto structure.

Related issue(s)

@maxipaz maxipaz requested a review from b00f August 12, 2024 20:37
@maxipaz maxipaz self-assigned this Aug 12, 2024
@maxipaz maxipaz changed the title refactor(grpc): Add Proposal to ConsensusInfo refactor(grpc): add Proposal to ConsensusInfo Aug 12, 2024
b00f
b00f requested changes Aug 13, 2024
View reviewed changes
www/grpc/proto/blockchain.proto Show resolved Hide resolved
www/grpc/proto/blockchain.proto Outdated Show resolved Hide resolved
@maxipaz maxipaz force-pushed the refactor/add-proposal-to-consensus-info branch 2 times, most recently from 94bea0d to b2fa94a Compare August 14, 2024 10:27
@maxipaz maxipaz marked this pull request as ready for review August 14, 2024 10:27
@maxipaz maxipaz requested a review from b00f August 14, 2024 10:27
b00f
b00f reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@b00f b00f left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep the numbers sequential. I suggest using Proposal as number 1 and ConsensusInfo as number 2. It is not backward compatible, but I don't think anyone has used this API so far.

@b00f b00f changed the title refactor(grpc): add Proposal to ConsensusInfo feat(grpc): add Proposal to ConsensusInfo Aug 15, 2024
@b00f b00f changed the title feat(grpc): add Proposal to ConsensusInfo feat(grpc): add Proposal to ConsensusInfo API Aug 15, 2024
b00f
b00f reviewed Aug 15, 2024
View reviewed changes
www/http/blockchain.go Outdated Show resolved Hide resolved
@maxipaz maxipaz force-pushed the refactor/add-proposal-to-consensus-info branch from b2fa94a to c50864c Compare August 23, 2024 11:50
@maxipaz maxipaz requested a review from b00f August 23, 2024 12:13
@b00f b00f merged commit 4e7052d into pactus-project:main Aug 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees

@maxipaz maxipaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Proposal to the ConsensusInfo API
2 participants
@maxipaz @b00f