Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include hdf5 library version as attribute in H5 file and run_info JSON #191

Open
warrenmcg opened this issue Nov 28, 2018 · 0 comments

Comments

@warrenmcg
Copy link

Hi @pimentel and @pmelsted,

The sleuth issues forum has received two separate reports from users that relate to an unexpected incompatibility between the hdf5 library version used in kallisto and that used in the rhdf5 library that underlies the read_kallisto_h5 and write_kallisto_h5 functions (pachterlab/sleuth#120 and pachterlab/sleuth#175).

Thus, I want to propose a feature request.

The incompatibility could be more easily identified in sleuth if kallisto included in the kallisto HDF5 output file an additional attribute to include the hdf5 library version used to construct the file, so that it could be easily accessed and checked against the hdf5 library version used by rhdf5 when reading the file. I think that would be the easiest solution from sleuth's end, though it could also work to use the run_info.json file. I think including the library version in both locations would be helpful to users.

I can't code in C++; otherwise, I would make the change myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant