Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxc-project/oxc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 79a5d02e3509a1c8db7e6638020f04e967e57c5d
Choose a base ref
...
head repository: oxc-project/oxc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 224c49069a03c7f52702aad692efaa8e6e597c4a
Choose a head ref
  • 4 commits
  • 13 files changed
  • 4 contributors

Commits on Jul 8, 2024

  1. fix(linter): incorrect fix in no-single-promise-in-promise-methods … 

    …rule; (#4094)

Closes #4093
    @DonIsaac
    DonIsaac committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1729249 View commit details
    Browse the repository at this point in the history

  2. Update README.md (#4102) 

    fix typo
    @fyzhu
    fyzhu authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    51eb8fe View commit details
    Browse the repository at this point in the history

  3. fix(isolated_declarations): Remove nested AssignmentPatterns from ins… 

    …ide parameters (#4077)

The default values in destructured parameters are retained in
declarations, which can cause captured variables to be part of the emit
when they shouldn't be. This can also lead to unnecessary isolated
declaration errors when those variables are themselves missing type
annotations and can't be inferred.

For example:
```ts
const x = 42;
const y = '';
export function fooGood3({a = x, b: [{c = y}]}: object): void {}
```

before this change will be emitted as:
```ts
declare const x = 42;
declare const y = '';
export declare function fooGood3({ a = x, b: [{ c = y }] }: object): void;
```

and after this change will be emitted as:
```ts
export declare function fooGood3({ a, b: [{ c }] }: object): void;
```

Co-authored-by: MichaelMitchell-at <=>
    @MichaelMitchell-at
    MichaelMitchell-at authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3fcad5e View commit details
    Browse the repository at this point in the history

  4. fix(isolated_declarations): Emit computed properties when they are we… 

    …ll known symbols
    @MichaelMitchell-at
    MichaelMitchell-at authored and MichaelMitchell-at committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    224c490 View commit details
    Browse the repository at this point in the history
Loading