Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to commit hash of a toolchain #144

Open
Nemo157 opened this issue Nov 10, 2023 · 3 comments
Open

Provide access to commit hash of a toolchain #144

Nemo157 opened this issue Nov 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Nemo157
Copy link

Nemo157 commented Nov 10, 2023

I would like to setup remapping of rust toolchain's CI paths to the local rust-src component, something similar to

rust-toolchain = pkgs.rust-bin.selectLatestNightlyWith (toolchain:
  toolchain.default.override {
    extensions = ["rust-src"];
  }
);

"--remap-path-prefix=/rustc/${rust-toolchain.commit}=/${rust-toolchain}/lib/rustlib/src/rust"

But afaict there's no way to access the commit hash of a selected toolchain.

@Nemo157
Copy link
Author

Nemo157 commented Nov 10, 2023

Hmmm, turns out this is maybe supposed to work automatically without config like this (rust-lang/rust#105907) and the config doesn't actually appear to work for these paths anyway. So 🤷 this does seem useful to have available still.

@oxalica
Copy link
Owner

oxalica commented Nov 10, 2023

I don't think it's possible currently, since we stripped all commit hashes from manifest to save space initially. They would add an additional ~100KB to the repo size, which seems acceptable to me. Just that we need a full refetch of manifests to include them for each versions.

@oxalica oxalica added the enhancement New feature or request label Nov 10, 2023
@Nadrieril
Copy link

I would quite like that as well. I currently get the toolchain commit by parsing ${toolchain}/share/doc/rust/html/version_info.html x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants