Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color property to the categories in license-classifications.yml #4150

Closed
tsteenbe opened this issue Jun 10, 2021 · 2 comments
Closed

Add color property to the categories in license-classifications.yml #4150

tsteenbe opened this issue Jun 10, 2021 · 2 comments
Labels
enhancement Issues that are considered to be enhancements model About the data model won't fix An issue that will not be fixed

Comments

@tsteenbe
Copy link
Member

Edit: But maybe we could add a color property to the categories in license-classifications.yml, and make use of them here.

Originally posted by @sschuberth in #4092 (comment)

@tsteenbe tsteenbe changed the title Add color color property to the categories in license-classifications.yml Add color property to the categories in license-classifications.yml Jun 10, 2021
@sschuberth
Copy link
Member

@tsteenbe, given that it's good practice to separate the data model from the visualization, I don't believe anymore that adding a color property to the license classification would be a good idea. If you agree, can we close this issue?

@sschuberth sschuberth added enhancement Issues that are considered to be enhancements model About the data model labels Feb 23, 2023
@sschuberth
Copy link
Member

As discussed in the community meeting, it's no the ORT configuration model that should associate colors (or in fact any visual representation) to semantics of the license classification. Instead, this should be a reporter-specific feature. In case of the web-app reporter, the proposal is to solve this via #2643 instead.

@sschuberth sschuberth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@sschuberth sschuberth added the won't fix An issue that will not be fixed label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are considered to be enhancements model About the data model won't fix An issue that will not be fixed
Projects
None yet
Development

No branches or pull requests

2 participants