Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error while trying to Request a quote from the SL #141

Open
yaroslavbr opened this issue Aug 19, 2021 · 3 comments
Open

JS error while trying to Request a quote from the SL #141

yaroslavbr opened this issue Aug 19, 2021 · 3 comments

Comments

@yaroslavbr
Copy link
Contributor

Summary
JS error while trying to Request a quote from the SL (After update from 4.1 to 4.2).

Steps to reproduce

  • click Request Quote btn in SL menu
    1

Actual Result
Nothing happens. Error in console -
app.js?version=1c451eee:180 Uncaught (in promise) Error: mediator.execute: get-line-items handler is not defined at Object.i.execute (app.js?version=1c451eee:180) at o.isConfirmationNeededFromOldShoppingList (oroshoppinglist.js?version=1c451eee:1) at o.isConfirmationNeeded (oroshoppinglist.js?version=1c451eee:1) at open (oroshoppinglist.js?version=1c451eee:1) at d.showConfirmDialog (commons.js?version=1c451eee:54) at d.<anonymous> (commons.js?version=1c451eee:54)

Expected Result
Confirmation popup should be show, no JS errors.

As I can see there is only one appearance of get-line-items in the file -

.

Initialization of this event was in - oro/commerce/src/Oro/Bundle/ShoppingListBundle/Resources/public/js/app/views/line-items-view.js which is removed in current version.

Details about your environment

  • OroCommerce version: 4.2
  • PHP version: 7.4
  • Database MySQL 8
@ValeriyYustunyk
Copy link
Contributor

Thank you, Yaroslav.
Internal ticket id: BB-20828

@yaroslavbr
Copy link
Contributor Author

@ValeriyYustunyk are there any update regarding this issue?

@ValeriyYustunyk
Copy link
Contributor

ValeriyYustunyk commented Feb 22, 2022

JS error should be already fixed and merged to maintenance/4.2.
But if you want to add Request to quote to the shopping list dropdown, you have to implement that logic by your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants