Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no squash] Misc improvements #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

dsseng
Copy link

@dsseng dsseng commented May 12, 2023

Thanks for maintaining this project! Here're my improvements. Please don't squash to keep logical history of changes.

  • Dropped PyQt5 to avoid combining Qt versions, we can do everything just fine with PySide6 only
  • Added DP832 (no A) specs from the device I use
  • Added direct USBTMC support, useful on Linux (usbtmc module uses device by default, so let's make use of that feature to avoid VISA)
  • Show connection errors in statusbar for user's convenience
  • Unlock the front panel after the application has been closed
  • Fix path to captures (was broken for UNIX paths, please re-check on Windows)
  • Misc fixes for UI/UX and docs (requirements.txt for installing deps)

dsseng added 10 commits May 12, 2023 14:39
Completely drop PyQt5 requirement as unnecessary
Derived from device marking
On Linux there's a kernel driver `usbtmc` which makes devices accessible as /dev/usbtmc*.
Support connecting to those devices without PyVISA making use of common file IO
Unlock the panel automatically when remote control is finished
Fix for small screens or not maximized window
self.channelSpecsDP83x.append({'DP832A':{'maxV':5 ,'maxI':3},'DP831':{'maxV':30,'maxI':2}})
self.channelSpecsDP83x.append({'DP832A':{'maxV':30,'maxI':3},'DP832':{'maxV':30,'maxI':3},'DP831':{'maxV':8 ,'maxI':5}})
self.channelSpecsDP83x.append({'DP832A':{'maxV':30,'maxI':3},'DP832':{'maxV':30,'maxI':3},'DP831':{'maxV':30,'maxI':2}})
self.channelSpecsDP83x.append({'DP832A':{'maxV':5 ,'maxI':3},'DP832':{'maxV':5 ,'maxI':3},'DP831':{'maxV':30,'maxI':2}})
Copy link
Author

@dsseng dsseng May 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we could set these limits to higher values. On DP832 it's 32V for 1 and 2 and 5.3V for CH3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant