Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping without @scarf/scarf #417

Closed
gbmeow opened this issue Mar 17, 2023 · 1 comment
Closed

Shipping without @scarf/scarf #417

gbmeow opened this issue Mar 17, 2023 · 1 comment

Comments

@gbmeow
Copy link

gbmeow commented Mar 17, 2023

I would like to understand if you are still shipping @scarf/scarf with your code. Would you need to turn it off, using #352 (comment) or if we should ignore the need to turn it off?
Reason: While @scarf/scarf is inside the package.json, it seems that npm packages, do not ship @scarf/scarf as a dependency

Currently
https://github.com/orizens/ngx-infinite-scroll/blob/master/package.json#L24 (@scarf/scarf)
https://www.npmjs.com/package/ngx-infinite-scroll/v/15.0.0?activeTab=code (no @scarf/scarf)

Reproduce
add "ngx-infinite-scroll": "^6.9.1", to package.json
SCARF_VERBOSE=true
run npm i

Result

[email protected] postinstall /Users/georgeb/node_modules/ngx-infinite-scroll
opencollective-postinstall || exit 0

sh: opencollective-postinstall: command not found

Nothing from @scarf/scarf

Is @scarf/scarf still being shipped to users of ngx-infinite-scroll?

@gbmeow
Copy link
Author

gbmeow commented Mar 17, 2023

Is this a matter of the gateway doing that for your package https://docs.scarf.sh/gateway/#figure_1?

@gbmeow gbmeow closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant