Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell Apache MINA SSHD that we are on Android #108

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

amberin
Copy link
Member

@amberin amberin commented Nov 28, 2023

There is code in MINA SSHD which uses the ReflectionException class, which is not present on Android. This code is not supposed to be run on Android, but the OsUtils.isAndroid() check apparently does not work.

Thankfully, there is a setAndroid() method.

@amberin
Copy link
Member Author

amberin commented Nov 28, 2023

This solves #107.

@amberin amberin linked an issue Nov 28, 2023 that may be closed by this pull request
There is code in MINA SSHD which uses the ReflectionException class,
which is not present on Android. This code is not supposed to be run on
Android, but the OsUtils.isAndroid() check apparently does not work.

Thankfully, there is a setAndroid() method.
@amberin amberin merged commit 27725a3 into orgzly-revived:master Nov 28, 2023
1 check passed
@amberin amberin deleted the sshd-reflection-exception branch November 28, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F-Droid can't build
1 participant