Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minting Off By 1 Error #3643

Closed
owenstrevor opened this issue Apr 21, 2024 · 4 comments · Fixed by #3659
Closed

Minting Off By 1 Error #3643

owenstrevor opened this issue Apr 21, 2024 · 4 comments · Fixed by #3659

Comments

@owenstrevor
Copy link

If a mint starts on block 40, ord will not let you mint until that block has already passed. Meaning the first block ord allows you to mint in is actually block 41.

@elder-rus
Copy link

I think there must something to ignore errors, I tried to find it last days, I think it's in core of ord wallet

@0xcruci
Copy link

0xcruci commented Apr 21, 2024

We identified the issue here:

if height < start {

It looks like the height might be the last confirmed block and is 1 behind. If that's the intent, then one fix would be to have the statement be: if height < (start - 1) or if (height + 1) < start

But perhaps there's a bug in height causing the off-by-one. Thanks!

Love, Pizza Ninjas

@bFanek
Copy link

bFanek commented Apr 21, 2024

this is fixed in this PR: #3645

@casey
Copy link
Collaborator

casey commented Apr 22, 2024

Fixed in #3659. Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants