Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send etch reveals until runes activate #3474

Closed
gmart7t2 opened this issue Apr 6, 2024 · 3 comments · Fixed by #3523
Closed

Don't send etch reveals until runes activate #3474

gmart7t2 opened this issue Apr 6, 2024 · 3 comments · Fixed by #3523
Labels
enhancement good first issue

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Apr 6, 2024

I am told that if you try to etch a rune on mainnet, ord will send the commit tx, wait for 6 confirmations, then send the reveal tx, whether or not runes are active yet.

It should wait until runes are active before sending the reveal tx.
@raphjaph
Copy link
Collaborator

raphjaph commented Apr 7, 2024

Jup, that would be a great feature!

@casey casey mentioned this issue Apr 11, 2024
Merged
@casey
Copy link
Collaborator

casey commented Apr 11, 2024

Jup, that would be a great feature!

lol "great feature" this is definitely a bug 😅

@gmart7t2 Thank you for reporting!

@raphjaph
Copy link
Collaborator

lol "great feature" this is definitely a bug 😅

A bug fix is also a great feature ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forbid etching below rune activation height casey/ord
3 participants
@casey @raphjaph @gmart7t2