Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rune wallet balances don't take divisibility into account #3438

Closed
gmart7t2 opened this issue Apr 1, 2024 · 3 comments
Closed

Rune wallet balances don't take divisibility into account #3438

gmart7t2 opened this issue Apr 1, 2024 · 3 comments

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Apr 1, 2024

ord wallet balance tells me I have 30000 GREG, but I really only have 3000 because the divisibility is 1:

$ ords3 balance
{
  "cardinal": 0,
  "ordinal": 1980,
  "runes": {
    "GREG": 30000,
    "GREG•GREG•GREG": 7535,
    "THESE•WILL•BE•WORTHLESS": 120
  },
  "runic": 70000,
  "total": 71980
}
$ ords3 send --fee-rate 1 tb1patp6wwevn5nmdg5fklnwf0uj2kz76qt3whntjysue62pmcsmx25s8hz74f 30000:GREG
error: insufficient `GREG` balance, only 3000 B in wallet

The interface should either always show the balance as 3000.0 or always show it as 30000. Currently it switches between the two.

Personally I would prefer if the amount was always shown with the correct number of decimal places, so "3000.0 B". They way we always know the last digit shown is the smallest denomination of the token and don't have to count the decimal digits to figure it out.

@twosatsmaxi
Copy link
Contributor

Looks like it's not the total supply but circulating supply It seems. Damn, naming is fucking confusing. We should have total supply and minted/circulating supply here @raphjaph @casey

@twosatsmaxi
Copy link
Contributor

image

@raphjaph
Copy link
Collaborator

Divisibility should now be accounted for in the wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants