Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from map panel original plugin -> data_layer -> GeoJSON layer type missing in Orchestracities plugin #82

Open
grabouillon06 opened this issue Aug 31, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@grabouillon06
Copy link

Hello,

not sure this is the right place to ask, so let me know.

It seems to me the GeoJSON data layer type is not available in the Orchestracities map panel. This data layer type is available in the original Grafana Map panel. Is there any reason it is so ?

I've seen in the code that could be just delayed as in the index.ts file, it is said "geojsonMapper, // dummy for now"

what would the current status ? and then what would be the guided line to activate it?

Also, I would be really interested how you have been able to extend the Orchestracities plugin the Grafana Map panel ? I've tried myself but bumped into a lot of dependency issues. any clue on that point ?

Thanks,

br,

Olivier Paviot

@chicco785
Copy link
Contributor

@grabouillon06
we forked the code in october 2021 from the grafana geomap, why working and not contributing directly there? we had quite some issues in getting accepted our PRs in the past because grafana is not really a community, the company behind it decide what's go in and what's not also based on their enterprise version goals.

the fact that it's a fork, of course brings disalignment, as the one you spotted. we are not interested in that data layer since we inserted geojson support in the marker layers.

said that, PRs to enhance the plugin are welcome.

w.r.t. the way we manage to create the fork, only for the plugin, it was with a lot sweat. not all libraries used to build it are part of grafana/data or grafana/ui. so we had to replicate the missing code in our repo and adapt it.

@grabouillon06
Copy link
Author

Hello chicco785, thank you very much for your quick answer. I'm quite new to Grafana and it clarifies a number of things. I agree contributing to the plugin would be really interesting, but I first need to check with my references in the context of the project.

@chicco785 chicco785 added enhancement New feature or request help wanted Extra attention is needed labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants