Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant build script reorganization for patches and clean-netbeans #234

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

sid-srini
Copy link
Member

  1. Placed patch files in separate lines to ease merges and reduce conflicts.

  2. Added string parsing and trimming of the patches list to allow for placing patch files in separate lines.

    • Also added a check for empty patch list when applying or unapplying the patches.
  3. Added a "clean-netbeans" target, similar to the "build-netbeans" target, to help in cleaning just the netbeans build artifacts.

1. Placed patch files in separate lines to ease merges and reduce conflicts.

2. Added string parsing and trimming of the patches list to allow for placing patch files in separate lines.
    - Also added a check for empty patch list when applying or unapplying the patches.

3. Added a "clean-netbeans" target, similar to the "build-netbeans" target, to help in cleaning just the netbeans build artifacts.

Signed-off-by: Siddharth Srinivasan <[email protected]>
@sid-srini sid-srini self-assigned this Aug 13, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 13, 2024
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating the build file

@Achal1607 Achal1607 merged commit 69846a9 into oracle:main Aug 13, 2024
3 checks passed
@sid-srini sid-srini deleted the ant-build-script-patches-cleanup branch August 13, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants