Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: False Positives on Activity/Fragment LocalTests #5434

Closed
adhiamboperes opened this issue Jun 20, 2024 · 1 comment
Closed

[BUG]: False Positives on Activity/Fragment LocalTests #5434

adhiamboperes opened this issue Jun 20, 2024 · 1 comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Jun 20, 2024

Describe the bug

Sometimes tests pass on the local tests that fail on their Espresso counterparts, and from observation this can be from logic bugs as much as test platform issues.

Steps To Reproduce

Run:

  1. HomeActivityLocalTest:testHomeActivity_onSubsequentLaunch_doesNotLogCompletedOnboardingEvent
    From a real run on the device you can see from the developer menu that the event is, infact logged. The same test copied to the androidTest file, fails.

  2. ExplorationActivityLocalTest: testExplorationActivity_updateGatingProvider_surveyGatingCriteriaMet_keepsSurveyDialog()

Expected Behavior

The above tests should fail, because manually testing the app contradicts the test behaviour.

Screenshots/Videos

No response

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

This issue tracks investigating the root cause of these false positives, and by extension should aim to identify if other tests show the same behaviour.

Should we verify that the domain/ui logic is the problem, seperate issues should be filed to fix those bugs.

@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). bug End user-perceivable behaviors which are not desirable. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Jun 20, 2024
@adhiamboperes
Copy link
Collaborator Author

I Could not reproduce this on develop. I most llikely experienced it from modifying adjacent code in my working branch. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

1 participant