Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Oppia GAE backend to provide download byte lengths #39

Closed
BenHenning opened this issue Aug 2, 2019 · 4 comments
Closed

Update Oppia GAE backend to provide download byte lengths #39

BenHenning opened this issue Aug 2, 2019 · 4 comments
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Sponsor Member

The Oppia GAE backend needs to provide download payload lengths to the frontend to enable progress-based downloads. This needs to be investigated since it's not clear whether large payloads can be downloaded in one stream, or if the backend needs a streaming service. Also, it's not clear whether the HTTP content length header is sufficient for this purpose, or if a custom length header needs to be provided.

This requires filing and tracking corresponding work items in https://github.com/oppia/oppia.
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Status: Blocked labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #5 since it will require extending that abstraction to include a way to retrieve payload sizes.

@BenHenning BenHenning changed the title Update Oppia GAE backend to provide download byte lengths Update Oppia GAE backend to provide download byte lengths [Blocked: #5] Aug 12, 2019
@BenHenning BenHenning modified the milestones: Prototype -- UI, Prototype -- Infra, Minimal Viable Product Sep 11, 2019
@BenHenning
Copy link
Sponsor Member Author

As mentioned in #45 this does not need to block the prototype since we don't need to show a download indicator for topics.

@BenHenning BenHenning changed the title Update Oppia GAE backend to provide download byte lengths [Blocked: #5] Update Oppia GAE backend to provide download byte lengths Sep 17, 2019
@BenHenning BenHenning modified the milestones: Minimal Viable Product, Global Availability, Beta Jun 23, 2020
@BenHenning
Copy link
Sponsor Member Author

@anandwana001 I think my comment above is now out-of-date. Let's follow the PRD for the thing we build.

@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 24, 2022
@BenHenning
Copy link
Sponsor Member Author

This has been replaced with the new proto API which will account for this.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenHenning @Broppia