Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are not rendering in multiple choice #3765

Closed
BenHenning opened this issue Sep 2, 2021 · 6 comments · Fixed by #3768
Closed

Images are not rendering in multiple choice #3765

BenHenning opened this issue Sep 2, 2021 · 6 comments · Fixed by #3768
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Sponsor Member

To repro: play through 'What is a Fraction?' until the question starting with '"Very good! Now look at these cakes,"'.

The multiple choice bullet list is blank (the images flicker before disappearing when navigating to the state):

image

Note that this was encountered on #3764. I haven't verified whether it is encountered on develop, but it's quite likely to be. We should find the root cause (https://github.com/oppia/oppia-android/wiki/Revert-&-regression-policy#how-to-find-the-offending-commit) and then determine what the fix should be, and whether a rollback is beneficial.

@BenHenning BenHenning added this to the Alpha MR3 milestone Sep 2, 2021
@BenHenning
Copy link
Sponsor Member Author

@anandwana001 since this is MR3 blocking, can you PTAL? This is higher priority than fixing KitKat support.

@BenHenning
Copy link
Sponsor Member Author

Odd. After leaving the device open for a while, the images eventually appeared. Maybe a weird internet flake that persisted?

@anandwana001
Copy link
Contributor

I will check this out.

@anandwana001
Copy link
Contributor

anandwana001 commented Sep 6, 2021

I checked with the latest develop branch, and I am seeing this issue with the single/multiple-choice question. This issue is the same we faced earlier too.

#3514

For me, What I did is move back to prev state and coming back to the state with these option and image showed up.

Screenshot_20210906_134239
Screenshot_20210906_133010

@anandwana001
Copy link
Contributor

After running app over multiple previous commits, I found a commit which is introducing this issue.
7505dd5

@rt4914 If you could help here with the fix or should we move to the revert and regression policy as per standard rule?

@BenHenning
Copy link
Sponsor Member Author

For searching context, this issue was found in 0.6-alpha (MR3).

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
2 participants