Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge completed_story_* files into individual xml file #3465

Closed
rt4914 opened this issue Jul 12, 2021 · 6 comments
Closed

Merge completed_story_* files into individual xml file #3465

rt4914 opened this issue Jul 12, 2021 · 6 comments
Assignees
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 12, 2021

Currently there are 4 versions of completed_story_item.xml file merge it into single xml file.
Currently there are 4 versions of completed_story_list_activity.xml file merge it into single xml file.
Currently there are 4 versions of completed_story_list_fragmentxml file merge it into single xml file.

How to find CompletedStoryList Screen.

  1. Open Test Topic 1 -> Lessons
  2. Finish Prototype Exploration and ImageRegionSelection Exploration.
  3. Open Home Screen -> Navigation Drawer
  4. Click Profile
  5. Click 1 Story Completed
  6. You will see CompletedStoryList screen.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.

@rt4914 rt4914 added good second issue Priority: Nice-to-have This work item is nice to have for its milestone. labels Jul 12, 2021
@rt4914 rt4914 added this to the Backlog milestone Jul 12, 2021
@rt4914 rt4914 added this to Needs Triage in CLAM Team (deprecated -- please use new board) via automation Jul 12, 2021
@rt4914 rt4914 moved this from Needs Triage to Backlog in CLAM Team (deprecated -- please use new board) Jul 12, 2021
@vrajdesai78
Copy link
Contributor

I want to work on this issue

@vrajdesai78
Copy link
Contributor

vrajdesai78 commented Aug 1, 2021

Hey @rt4914, in completed_story_item.xml file how to manage below code to merge it into single file. I have already write dimensions in dimens.xml file but don't know how to work on below code.

image


Also I am getting below error while running completed_story in tablet portrait mode.

image

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 4, 2021

@vrajdesai78 You might need to remove topRoundedRectDrawableWithColor if its not affecting the before/after images.

If it is affecting the UI then in this case we might need to keep atleast 2 files for this xml. One file without topRoundedRectDrawableWithColor and one file with topRoundedRectDrawableWithColor

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 11, 2021

@vrajdesai78 Any updates on this?

@vrajdesai78
Copy link
Contributor

@rt4914 Hey, can you help me out I am getting error which I have mentioned above even after keeping at least 2 files one for smartphone and another for tablet. Can you help me out.

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 16, 2021

@rt4914 Hey, can you help me out I am getting error which I have mentioned above even after keeping at least 2 files one for smartphone and another for tablet. Can you help me out.

@vrajdesai78 Whenever you delete any tablet xml file make sure you install the app from the device, rebuild the app and then install it. This should solve your error.

@rt4914 rt4914 closed this as completed in 392b1ad Sep 1, 2021
CLAM Team (deprecated -- please use new board) automation moved this from Backlog (things to organize into workstreams) to Closed Sep 1, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
No open projects
Development

No branches or pull requests

3 participants