-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge completed_story_* files into individual xml file #3465
Comments
I want to work on this issue |
Hey @rt4914, in completed_story_item.xml file how to manage below code to merge it into single file. I have already write dimensions in dimens.xml file but don't know how to work on below code.
|
@vrajdesai78 You might need to remove If it is affecting the UI then in this case we might need to keep atleast 2 files for this xml. One file without |
@vrajdesai78 Any updates on this? |
@rt4914 Hey, can you help me out I am getting error which I have mentioned above even after keeping at least 2 files one for smartphone and another for tablet. Can you help me out. |
@vrajdesai78 Whenever you delete any tablet xml file make sure you install the app from the device, rebuild the app and then install it. This should solve your error. |
Currently there are 4 versions of
completed_story_item.xml
file merge it into single xml file.Currently there are 4 versions of
completed_story_list_activity.xml
file merge it into single xml file.Currently there are 4 versions of
completed_story_list_fragmentxml
file merge it into single xml file.How to find CompletedStoryList Screen.
Test Topic 1
->Lessons
Prototype Exploration
andImageRegionSelection Exploration
.1 Story Completed
CompletedStoryList
screen.We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in
dimens.xml
file and use it accordingly.Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
The text was updated successfully, but these errors were encountered: