Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StoryProgressController #21

Closed
Tracked by #3610
BenHenning opened this issue Aug 2, 2019 · 5 comments · Fixed by #1
Closed
Tracked by #3610

Implement StoryProgressController #21

BenHenning opened this issue Aug 2, 2019 · 5 comments · Fixed by #1
Assignees
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Sponsor Member

BenHenning commented Aug 2, 2019

Users will make progress on individual stories when they play them. There should be a system that can be used to record and retrieve this state based on the story being played (by ID) and profile ID of the user playing it. Note that this system is storing based on individual exploration being played in the context of a story.

The actual storage necessary here is just completed exploration IDs that can be cross-referenced with the exploration IDs contained in a story.

@BenHenning BenHenning added Type: Improvement Priority: Nice-to-have This work item is nice to have for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning BenHenning added this to Triage in Ship Oppia on Android via automation Aug 2, 2019
@BenHenning
Copy link
Sponsor Member Author

This depends on #15 and #14.

@BenHenning BenHenning moved this from Triage to Blocked in Ship Oppia on Android Aug 2, 2019
@BenHenning BenHenning changed the title Story progress management system Story progress management system [Blocked: #14, #15] Aug 12, 2019
@BenHenning
Copy link
Sponsor Member Author

This does not block on #14 since profiles may not be implemented in the prototype. #14 will need to add profile support to this data store after it's completed.

@BenHenning BenHenning changed the title Story progress management system [Blocked: #14, #15] Story progress management system Sep 17, 2019
@BenHenning BenHenning changed the title Story progress management system Implement StoryProgressController Sep 17, 2019
@BenHenning BenHenning changed the title Implement StoryProgressController Implement StoryProgressController [Blocked: #119] Sep 17, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #119.

@BenHenning
Copy link
Sponsor Member Author

NB #118 might actually include progress for chapters per the requirements of the topic page. Either that impl needs to depend on this to derive progress, or both should use a common source. Perhaps what we really want is a StoryController for the story page, and use an internal StoryProgressController to determine progress.

Or, the TopicController can be used to report summaries for topic & summary pages, but the actual progress is controlled by this controller. That may be a nicer way to model things for now.

@BenHenning BenHenning changed the title Implement StoryProgressController [Blocked: #119] Implement StoryProgressController Sep 30, 2019
@BenHenning BenHenning self-assigned this Sep 30, 2019
@BenHenning
Copy link
Sponsor Member Author

This has been completed a while ago.

Ship Oppia on Android automation moved this from Blocked to Done Jun 23, 2020
Prototype Oppia on Android automation moved this from In progress to Done Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
@BenHenning BenHenning linked a pull request Sep 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

2 participants