[BUG]: Arabic and Portuguese lessons are missing images #719
Assignees
Labels
bug
Something isn't working
Comments
|
Traced this to oppia/oppia-android@fbf58d7 which sets up the images from text (content description text |
adhiamboperes
changed the title
adhiamboperes
changed the title
|
Edited issue title because both languages are affected. |
|
@adhiamboperes Thanks, this is a great find! It's not a guarantee yet on the server that every image embedding has the necessary alt text, though this is something we do plan to look into (there are a bunch of older image translations which do not). I didn't realize Android was relying on the existence of alt text so strongly though. Is it possible to modify things so that images without alt text can still be displayed? |
|
Also @adhiamboperes -- just to confirm, checkouts before the commit you mention result in the necessary images showing? |
|
It is possible to add some logic to show images using the non-interactive-image attribute. I believe the reason the alt-text usage was introduced was for a11y, as per oppia/oppia-android#3432 |
|
If we were to show images using the non-interactive-image attribute, what impact does that have on a11y? |
I haven't verified that yet, but what we did verify, (@BenHenning also) was that modifying some of the logic introduced in the commit allowed the images to display. |
My best guess right now is that the content description of an image would not be read out by TalkBack. |
|
Ah ok. Will that be the case for all images, not just the missing ones?
(If the former, that would be a problem. If the latter, then it's fine.)
|
|
FYI this is effectively shares a root cause with #718, though that also is caused by pipeline issues. |
adhiamboperes
referenced
this issue
in adhiamboperes/oppia-android
Jun 9, 2023
oppia#5040) ## Explanation Fixes #5022 Fixes #5030 Fixes oppia#5031 First, it was found during investigation that some images aren't showing up in Arabic or Brazilian Portuguese translations of lessons due to their image control character (that indicates to Android an image needs to be rendered) being replaced by empty reading text. This has been addressed with a more robust content description check and three new tests to detect this case and addresses #5022 and #5030. This was determined due to an excellent investigation & finding by @adhiamboperes. Second, some specific images wouldn't render in Arabic specifically. This was due to a bug in AndroidSVG (our dependency library used for rendering SVG files). Per https://github.com/oppia/androidsvg/blob/4bc1d26412f0fb9fd4ef263fa93f6a64f4d4dbcf/androidsvg/src/main/java/com/caverock/androidsvg/utils/CSSFontVariationSettings.java#L73 AndroidSVG uses ``DecimalFormat`` to format certain CSS font settings (particularly in the case for dynamic fonts), and AndroidSVG isn't following the conventional advice of https://developer.android.com/reference/java/util/Locale (under "Be wary of the default locale") and https://docs.oracle.com/javase/8/docs/api/java/text/DecimalFormat.html (specific advice to create formatters for specific locales). In summary, AndroidSVG was formatting certain CSS parameters to floats without accounting for the fact that the default locale may change the numeral system when formatting those decimals. A patch to Oppia's fork of AndroidSVG fixes this problem (oppia/androidsvg@1265eb1). Note that this fix will also be included in the later AndroidSVG changes that the app will later be moved to. Additionally, these are unfortunately not changes that can be easily tested without finding specific SVGs to include in tests, and either scanning logcat or relying on screenshot testing. A more suitable testing strategy would be end-to-end tests vis-a-vis oppia#3839. Third, bullets weren't rendering correctly in Arabic views of lessons (oppia#5031). This was due to two issues: 1. The previous logic was always assuming a rightward shift to center the bullet which doesn't work in RTL. 2. The previous logic was using the canvas width to invert X coordinates rather than the clipped space. This wasn't caught previously because the main tested content for bullets was a test revision card whose content spans the width of the screen (which corresponds to the drawing area of the canvas). However, lessons use a more constrained area due to content margins, so the bullets were being placed off screen in the margin whitespace that was being clipped. See the following screenshots for a demonstration of the new content description tests failing without the fix, and passing with it: | Without fix | With fix | |--------|--------| |  |  | A few caveats with the bullet fixes: - The FAQ bullets will still not render correctly in Arabic (technically in all non-English languages) due to oppia#5034 which requires fixes in the translation strings. They're actually missing the necessary markup elements needed to show their bullet lists correctly. - The FAQ style fix can only be tested via basic measurement verification, but fortunately the existing test did require an update and changed in the expected way (the calculated x position of the bullets in the test have moved left 18 pixels). This isn't nearly as good as a visual test, but that will require oppia#1815 to be finished, first. **Note** that this PR will need to be cherry-picked into the 0.11 release branch. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only Demonstrations of fixes for #5022 (note that, for the first Arabic screenshots, the lesson image isn't actually localized in the content; also, the Naija image does load without the PR fixes but it can be a bit delayed): | Before (without fixes) | After (with the fixes of this PR) | |--------|--------| |  |  | |  |  | |  |  | Demonstrations of fixes for #5030 (only some images actually hit this bug): | Before (without fixes) | After (with the fixes of this PR) | |--------|--------| |  |  | |  |  | |  |  | Demonstrations of fixes for #5022, #5030, and oppia#5031 (since Arabic lessons have conflated failures for images, and some of these images also demonstrate the bullet list issue): | Before (without fixes) | After (with the fixes of this PR) | |--------|--------| |  |  | |  |  | |  |  | --------- Co-authored-by: Adhiambo Peres <[email protected]>
|
Image is missing in the Fractions chapter in 5th page screen-20230612-152522.mp4 |
|
This is a content issue, transferring to lessons team. |
|
Hi. Is there any estimate on when this might get fixed? It's considered a priority issue for Oppia Android, so it'd be nice to understand a rough timeline so that we can plan accordingly when this might be available to ship to production. |
|
This is now fixed on the website. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Some images are missing in Arabic versions of the lessons. This is serious because learners will not be able to proceed through the lessons without those images.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All images should show up in the lesson.
Demonstration
Environment
The text was updated successfully, but these errors were encountered: